Skip to content

fix(ci): drop secrets: inherit from titus secrets-scan caller (least-privilege)#83

Merged
nsportsman merged 1 commit into
mainfrom
fix/titus-drop-secrets-inherit
Jun 3, 2026
Merged

fix(ci): drop secrets: inherit from titus secrets-scan caller (least-privilege)#83
nsportsman merged 1 commit into
mainfrom
fix/titus-drop-secrets-inherit

Conversation

@nsportsman

@nsportsman nsportsman commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Why

The titus-scan.yml reusable declares no secrets: block — it only uses
GITHUB_TOKEN, which GitHub Actions auto-grants to called reusable workflows
without secrets: inherit. So secrets: inherit here forwarded this repo's
entire secret store to the reusable for nothing — an unnecessary blast-radius
expansion that violates least-privilege (GitHub Well-Architected: "Avoid
secrets: inherit … pass only required secrets").

This drops secrets: inherit from the calling job. Scanner behavior is
unchanged (jupiter #293 already runs green without it). Permissions and
fail-on-findings are untouched.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nsportsman, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ae9d394-670c-4ff4-96f3-bec33aa62fe7

📥 Commits

Reviewing files that changed from the base of the PR and between 9071bae and 9c5add5.

📒 Files selected for processing (1)
  • .github/workflows/secrets-scan.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/titus-drop-secrets-inherit

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Claude review skipped — non-code PR (only changed files matching docs/**, .github/**, .claude-plugin/**, *.md, *.txt, images, or license-like files). Post @claude on a review comment to force a review.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Gemini review skipped — non-code PR (only changed files matching docs/**, .github/**, .claude-plugin/**, *.md, *.txt, images, or license-like files). Post @gemini on a review comment to force a review.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codex review skipped — non-code PR (only changed files matching docs/**, .github/**, .claude-plugin/**, *.md, *.txt, images, or license-like files). Post @codex on a review comment to force a review.

@nsportsman nsportsman merged commit fb79dc3 into main Jun 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nsportsman